Fix error handling and missing await in ingest pipeline#14
Merged
Conversation
- Wrap ora spinner in try/catch so it calls .fail() on load errors - Await storeChunks so insert errors surface instead of being silently dropped - Move 🧂 console.log after spinner completes to avoid corrupting terminal output - Wrap embedChunks progress bar in try/finally so bar.stop() always runs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oraspinner intry/catchso it calls.fail()with the error message instead of hanging on load errorsawait storeChunks(...)— previously unawaited, so insert errors were silently dropped and the pipeline appeared to succeed🧂 Enriched chunks with metadatalog to afterloadSpinner.succeed()to avoid corrupting the spinner outputembedChunksprogress bar intry/finallysobar.stop()always runs even ifembedManythrowsTest plan
bun run ingestagainst the vault and verify the spinner, progress bar, and success logs display cleanly🤖 Generated with Claude Code